Skip to content

Update version to v1.1.0#10223

Open
ripatel-fd wants to merge 1 commit into
mainfrom
ripatel/1.1.0
Open

Update version to v1.1.0#10223
ripatel-fd wants to merge 1 commit into
mainfrom
ripatel/1.1.0

Conversation

@ripatel-fd

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 12, 2026 22:47

This comment was marked as spam.

@greptile-jt

greptile-jt Bot commented Jun 12, 2026

Copy link
Copy Markdown

Greptile Summary

Bumps the Firedancer version from 0.1.1 to 1.1.0 by updating the weak symbols in src/util/fd_version.c. The major version changes from 0 to 1 and the patch version from 1 to 0, aligning with the project's stated plan that "the first full Firedancer release will be version 1.0" (per with-version.mk).

  • The version symbols use __attribute__((weak)), so this only affects the pure Firedancer build. The Frankendancer (fdctl) build overrides these with strong symbols derived from src/app/fdctl/version.mk (which remains at 0.1.1).
  • Version values propagate correctly to gossip contact info, logging, and the version CLI command.
  • No tests assert against specific version numbers, so no test changes are needed.

Confidence Score: 5/5

This PR is safe to merge — it is a straightforward version constant update with no logic changes.

The change modifies only two integer constants in weak symbol definitions. The version propagation mechanism is well-understood (weak/strong symbol pattern), no tests depend on specific version values, and the Frankendancer build path is unaffected.

No files require special attention.

Important Files Changed

Filename Overview
src/util/fd_version.c Simple version bump: fd_major_version 0→1, fd_patch_version 1→0, yielding version string 1.1.0. No logic changes.

Sequence Diagram

sequenceDiagram
    participant VC as fd_version.c (weak)
    participant FV as fdctl/version.c (strong)
    participant Boot as fd_version_private_boot
    participant Log as fd_log / gossip / CLI

    alt Pure Firedancer build
        VC->>Boot: fd_major=1, fd_minor=1, fd_patch=0
    else Frankendancer (fdctl) build
        FV->>Boot: fd_major/minor/patch from version.mk (overrides weak)
    end
    Boot->>Boot: sprintf → fd_version_cstr "1.1.0"
    Boot->>Log: Version available for logging, gossip, CLI
Loading

Reviews (1): Last reviewed commit: "Update version to v1.1.0" | Re-trigger Greptile

@github-actions

Copy link
Copy Markdown

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-424669000-perf per slot 0.050926 s 0.050745 s -0.355%
backtest mainnet-424669000-perf snapshot load 1.562 s 1.57 s 0.512%
backtest mainnet-424669000-perf total elapsed 65.999704 s 65.765502 s -0.355%
firedancer mem usage with mainnet.toml 506.46 GiB 506.46 GiB 0.000%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants