disco: fix pack_execle MTU depth#10062
Open
ripatel-fd wants to merge 1 commit into
Open
Conversation
Cosmetic-only fix making pack_execle use a centrally defined MTU parameter instead of USHORT_MAX
ripatel-fd
force-pushed
the
ripatel/execle-constants
branch
from
9e6d8fa to
b455e69
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the MTU used for the pack_execle topology link by replacing a hard-coded USHORT_MAX with the semantic constant MAX_MICROBLOCK_SZ, aligning the topology configuration with the pack/microblock size definitions used elsewhere in Disco.
Changes:
- Use
MAX_MICROBLOCK_SZinstead ofUSHORT_MAXfor thepack_execlelink MTU in the Firedancer topology. - Simplify/adjust a compile-time size assertion in the execle tile to reference the execle→PoH path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/discof/execle/fd_execle_tile.c |
Updates the static assertion naming/scope around the execle→PoH microblock trailer sizing. |
src/app/firedancer/topology.c |
Switches pack_execle link MTU from USHORT_MAX to MAX_MICROBLOCK_SZ (centralized microblock size constant). |
Performance Measurements ⏳
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosmetic-only fix making pack_execle use a centrally defined MTU
parameter instead of USHORT_MAX