eqvoc: fix swapped arguments to eqvoc_chunk_insert

[intrigus-lgtm]

No description provided.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a CI-gated “lint” that validates Local.mk macro usage and ensures unit tests built via make-unit-test are also registered via run-unit-test, while updating various Local.mk files to either run the tests or explicitly opt out.

Changes:

• Introduces contrib/lint/check_makefiles.py, adds a make lint target, and wires it into GitHub Actions.
• Registers several previously-built unit tests to run by default and fixes a couple of $(call ...) typos.
• Adds # lint-no-run-unit-test annotations for tests that are intentionally not runnable under default CI conditions.

Reviewed changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/vinyl/Local.mk	Adds lint opt-out annotation for a topology-dependent unit test
src/util/wksp/Local.mk	Annotates a problematic unit test and adjusts which tests run by default
src/util/tpool/Local.mk	Registers test_tpool to run
src/util/tmpl/Local.mk	Registers additional template/container tests to run (incl. hosted-only concurrent test)
src/util/simd/Local.mk	Fixes a run-unit-test invocation typo so the test actually runs
src/util/shmem/Local.mk	Registers test_shmem to run
src/util/sandbox/Local.mk	Registers test_sandbox to run
src/util/net/Local.mk	Adds lint opt-out annotation for a CLI/input-dependent test
src/util/log/Local.mk	Registers test_log to run
src/util/bits/Local.mk	Registers test_bits_tg to run
src/tango/cnc/Local.mk	Adds lint opt-out annotation for a multi-tile dependent test
src/flamenco/runtime/Local.mk	Registers test_hashes to run; annotates a broken test as opted out
src/flamenco/log_collector/Local.mk	Annotates a broken test as opted out
src/flamenco/accdb/Local.mk	Registers test_accdb_v0 to run
src/discof/restore/Local.mk	Adds lint opt-out annotation for a CLI-arg-dependent test
src/discof/forest/Local.mk	Annotates a broken test as opted out
src/disco/keyguard/Local.mk	Registers test_keyload to run
src/choreo/eqvoc/test_eqvoc.c	Updates call sites to match reordered fd_eqvoc_chunk_insert parameters
src/choreo/eqvoc/fuzz_eqvoc.c	Updates fuzzer call site to match reordered fd_eqvoc_chunk_insert parameters
src/choreo/eqvoc/Local.mk	Annotates a broken unit test as opted out
src/choreo/Local.mk	Registers test_choreo_base to run
src/ballet/sbpf/Local.mk	Adds lint opt-out annotation for a CLI-arg-dependent test
src/ballet/reedsol/Local.mk	Registers test_reedsol to run
src/ballet/pb/Local.mk	Registers test_pb to run
src/ballet/lthash/Local.mk	Registers test_lthash to run
src/ballet/hmac/Local.mk	Fixes a run-unit-test invocation typo so the test actually runs
src/ballet/bigint/Local.mk	Fixes macro name typo (add-hdrs)
src/ballet/aes/Local.mk	Registers test_aes to run
contrib/lint/check_makefiles.py	Adds the Makefile/Local.mk linter implementation
config/everything.mk	Adds lint target and help text; includes it in aux rules
.github/workflows/on_pull_request.yml	Adds a lint job to the PR workflow
.github/workflows/lint.yml	Adds a reusable workflow that runs make lint

Comments suppressed due to low confidence (1)

src/util/wksp/Local.mk:1

• The opt-out reason appears broken? is ambiguous and makes it hard to know whether this is a temporary CI issue vs. a known defect. Consider replacing it with a concrete failure mode and/or a tracked reference (e.g., TODO(issue #): crashes on ...), so the annotation can be revisited and removed when fixed.

[ripatel-fd]

Please rebase

[intrigus-lgtm]

Rebased.