flamenco: fix UAF in log_collector test#10049
Closed
intrigus-lgtm wants to merge 7 commits into
Closed
Conversation
Will be fixed in a separate PR.
intrigus-lgtm
requested review from
emwang-jump,
lidatong and
ripatel-fd
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a repo linter for Local.mk files and tightens CI enforcement by ensuring unit tests are either registered to run by default or explicitly annotated as exceptions.
Changes:
- Introduces
make lint(and CI job) to detect unknown$(call ...)macro names and unit tests that are built but not run. - Registers many existing unit tests with
run-unit-test, and annotates intentional exceptions with# lint-no-run-unit-test. - Fixes a few build-macro typos in
Local.mkfiles.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vinyl/Local.mk | Annotates a unit test as intentionally not run by default. |
| src/util/wksp/Local.mk | Annotates a unit test as intentionally not run; adjusts default run list. |
| src/util/tpool/Local.mk | Registers test_tpool to run by default. |
| src/util/tmpl/Local.mk | Registers additional template/container tests to run by default. |
| src/util/simd/Local.mk | Fixes a typo so an AVX unit test is actually registered to run. |
| src/util/shmem/Local.mk | Registers test_shmem to run by default. |
| src/util/sandbox/Local.mk | Registers test_sandbox to run by default. |
| src/util/net/Local.mk | Annotates test_pcap as intentionally not run by default. |
| src/util/log/Local.mk | Registers test_log to run by default. |
| src/util/bits/Local.mk | Registers an additional bits unit test to run by default. |
| src/tango/cnc/Local.mk | Annotates test_cnc as intentionally not run by default. |
| src/flamenco/runtime/Local.mk | Registers test_hashes; annotates a broken test as not run. |
| src/flamenco/log_collector/test_log_collector.c | Adjusts log collector usage in a test helper. |
| src/flamenco/log_collector/Local.mk | Registers test_log_collector to run by default. |
| src/flamenco/accdb/Local.mk | Registers test_accdb_v0 to run by default. |
| src/discof/restore/Local.mk | Annotates a CLI-arg-dependent unit test as not run by default. |
| src/discof/forest/Local.mk | Annotates a broken unit test as not run by default. |
| src/disco/keyguard/Local.mk | Registers test_keyload to run by default. |
| src/choreo/eqvoc/Local.mk | Annotates a broken unit test as not run by default. |
| src/choreo/Local.mk | Registers test_choreo_base to run by default. |
| src/ballet/sbpf/Local.mk | Annotates a CLI-arg-dependent unit test as not run by default. |
| src/ballet/reedsol/Local.mk | Registers test_reedsol to run by default. |
| src/ballet/pb/Local.mk | Registers test_pb to run by default. |
| src/ballet/lthash/Local.mk | Registers test_lthash to run by default. |
| src/ballet/hmac/Local.mk | Fixes typo so test_hmac is registered to run. |
| src/ballet/bigint/Local.mk | Fixes typo in header macro call (add-hdrs). |
| src/ballet/aes/Local.mk | Registers test_aes to run by default. |
| contrib/lint/check_makefiles.py | Adds the Local.mk linter (unknown macros + built-but-not-run tests). |
| config/everything.mk | Adds lint target and integrates it into help/phony rules. |
| .github/workflows/on_pull_request.yml | Adds a lint job to PR CI. |
| .github/workflows/lint.yml | New reusable workflow that runs make lint. |
| $(call make-unit-test,test_wksp_admin,test_wksp_admin,fd_util) | ||
| $(call make-unit-test,test_wksp_user,test_wksp_user,fd_util) | ||
| $(call make-unit-test,test_wksp_helper,test_wksp_helper,fd_util) | ||
| $(call make-unit-test,test_wksp_helper,test_wksp_helper,fd_util) # lint-no-run-unit-test, appears broken? |
| $(call make-unit-test,test_bundle_exec,test_bundle_exec,fd_flamenco fd_funk fd_ballet fd_util) | ||
| $(call run-unit-test,test_bundle_exec) | ||
| $(call make-unit-test,test_runtime_alut,test_runtime_alut,fd_flamenco fd_funk fd_ballet fd_util) | ||
| $(call make-unit-test,test_runtime_alut,test_runtime_alut,fd_flamenco fd_funk fd_ballet fd_util) # lint-no-run-unit-test, TODO: currently broken test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes and depends on #10048 being merged.