feat(test): add Graviton5 (Neoverse V3) CPU feature baselines#6039
Draft
not4s wants to merge 1 commit into
Draft
feat(test): add Graviton5 (Neoverse V3) CPU feature baselines#6039not4s wants to merge 1 commit into
not4s wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6039 +/- ##
=======================================
Coverage 82.85% 82.85%
=======================================
Files 277 277
Lines 30633 30633
=======================================
Hits 25381 25381
Misses 5252 5252
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Register Graviton5 so the aarch64 CPU feature tests recognise it:
- utils_cpuid.py: add the ARM_NEOVERSE_V3 CpuModel and map MIDR part
0xd84 (r0p1) to it.
- test_cpu_features_aarch64.py: G5_FEATS = G4_FEATS | {afp, ecv} and
the ARM_NEOVERSE_V3 match cases for the default and SVE/PAC
templates. wfxt (FEAT_WFxT) reaches the guest from the 6.1 guest
kernel, so add it to the guest baseline when the guest kernel is
>= 6.1.
- test_cpu_features_host_vs_guest.py: add the ARM_NEOVERSE_V3 case.
Same SVE/PAC host-only set as G4, plus the shared ssbs host/guest
handling.
Feature sets captured on m9g.metal-48xl across 5.10/6.1/6.18 hosts.
Signed-off-by: Jay Chung <jaehoc@amazon.com>
not4s
force-pushed
the
jaehoc/g5-cpu-baseline
branch
from
July 17, 2026 16:52
79cf1a9 to
c5f231d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Registers AWS Graviton5 (Neoverse V3, MIDR part 0xd84) so the aarch64 CPU-feature tests recognise it:
Reason
Part of onboarding AWS Graviton5 (m9g.metal) to Firecracker. The aarch64 CPU-feature tests key off the CPU model, so on a Graviton5 host they currently fall through (unrecognised MIDR 0xd84) and fail. Registering V3 with its expected guest feature set lets test_cpu_features_aarch64 and test_cpu_features_host_vs_guest pass on G5, following the same pattern used for G4 (Neoverse V2).
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.