Repository navigation
fix(fork): merge upstream db0ae7b into patch/sqlite-reader-pool - #270
Merged
fireboltdude1357 merged 435 commits intoNov 14, 2026
Merged
fireboltdude1357 merged 435 commits into
fireboltdude1357 merged 435 commits into
Conversation
…al default branch (pingdotgg#36379)
…rvice worker badge call no longer causes one (pingdotgg#36389)
…ingdotgg#23620) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…mposer after a lost launch reply (pingdotgg#32330)
…nt when auto-compaction is off (pingdotgg#36417)
…into the composer (pingdotgg#36436)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#36218) Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…pingdotgg#28469) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#35712) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…es (pingdotgg#25872) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…tHub API rejects the request (pingdotgg#28339) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…t a project until restart (pingdotgg#36704) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…36712) Co-authored-by: Grok 4.7 <noreply@x.ai> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…gdotgg#28968) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…selects (pingdotgg#28388) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…text" (pingdotgg#28535) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…rry-pick and reftable cherry-picks (pingdotgg#28912) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…overlap (pingdotgg#29028) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…erver address (pingdotgg#28348) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ngdotgg#28375) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…pingdotgg#28575) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…#36647) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…t folder labels (pingdotgg#28644) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ngdotgg#36732) Co-authored-by: Julius Marminge <julius0216@outlook.com>
… review diff (pingdotgg#28632) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…g#29376) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#36726) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#28581) Co-authored-by: nikolay.akinshin <nikolay.akinshin@south.rt.ru> Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
pingdotgg#28850) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…#28391) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#28851) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…te-reader-pool-upstream-db0ae7b # Conflicts: # packages/shared/src/nodeSqliteClient.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fork's nightly build fails because
patch/sqlite-reader-poolconflicts with upstream db0ae7b inpackages/shared/src/nodeSqliteClient.ts(4 hunks).Upstream pingdotgg#27979 ("queued SQLite reads stop waiting on one reader while another is free") now does what this patch was for. It replaces claim-count routing with one admission semaphore across all readers, takes the lowest free slot first, and counts admission in the lock wait. The patch's own upstream PR, pingdotgg#24762, was closed without merging.
I took upstream's
nodeSqliteClient.tsas is and kept the patch's 4 pool tests innodeSqliteClient.test.ts:All 4 pass against upstream's implementation in 5 out of 5 runs, so they now only guard upstream's behavior. The branch differs from upstream only by those 143 test lines. Removing the patch from
.github/fork-patches.txtis a separate change.On a scratch stack of upstream db0ae7b with all 26 patches and this branch,
pnpm install --no-frozen-lockfile,vp run typecheck(41 of 41) andvp test runon the test files the patches touch, plusSqlite.test.ts, all pass (50 files, 1433 tests).Made by Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code