fix: collect pod logs after helm test (FB-1643)#2
Merged
Conversation
dig-whois
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
FB-1643: collect pod logs after helm test
Summary
helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded deletes test pods the moment they succeed, so
helm test --logsraces and exits 1 with "pods not found" even when every suite passed (helm/helm#8949). Drop hook-succeeded from every test under helm/templates/tests/; pods are still cleaned up on the next test run by before-hook creation, andmake test-cleanupremains for explicit cleanup.Test Plan
make test