Skip to content

fix(fdc): block reconnecting if there are no active subscribers or pending unary calls.#18265

Merged
aashishpatil-g merged 2 commits intomainfrom
ap/reconnectFixes
May 8, 2026
Merged

fix(fdc): block reconnecting if there are no active subscribers or pending unary calls.#18265
aashishpatil-g merged 2 commits intomainfrom
ap/reconnectFixes

Conversation

@aashishpatil-g
Copy link
Copy Markdown
Contributor

The current logic schedules a reconnect if channel disconnects due to network or errors.
This PR modifies the logic to not reconnect if there are no active subscribers or pending unary calls.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@aashishpatil-g aashishpatil-g requested a review from cynthiajoan May 8, 2026 14:49
@aashishpatil-g aashishpatil-g changed the title bug(fdc): Reconnect fixes fix(fdc): Reconnect fixes May 8, 2026
@aashishpatil-g aashishpatil-g changed the title fix(fdc): Reconnect fixes fix(fdc): Reconnect checks May 8, 2026
@russellwheatley russellwheatley changed the title fix(fdc): Reconnect checks fix(fdc): block reconnecting if there are no active subscribers or pending unary calls. May 8, 2026
@russellwheatley
Copy link
Copy Markdown
Member

@aashishpatil-g - web fdc CI is failing on the test in this PR: https://github.com/firebase/flutterfire/actions/runs/25562216211/job/75036477330?pr=18265#step:12:79

Converted integration test to unit to access private function.
@aashishpatil-g aashishpatil-g merged commit 330bbb8 into main May 8, 2026
31 of 35 checks passed
@aashishpatil-g aashishpatil-g deleted the ap/reconnectFixes branch May 8, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants