fix(fdc): block reconnecting if there are no active subscribers or pending unary calls.#18265
fix(fdc): block reconnecting if there are no active subscribers or pending unary calls.#18265aashishpatil-g merged 2 commits intomainfrom
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
@aashishpatil-g - web fdc CI is failing on the test in this PR: https://github.com/firebase/flutterfire/actions/runs/25562216211/job/75036477330?pr=18265#step:12:79 |
Converted integration test to unit to access private function.
The current logic schedules a reconnect if channel disconnects due to network or errors.
This PR modifies the logic to not reconnect if there are no active subscribers or pending unary calls.