Analytics: Add apple store kit 2 support#1460
Open
AustinBenoit wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for Apple's StoreKit 2 transactions in Firebase Analytics by adding the LogAppleTransactionAsync method. The update includes necessary SWIG configurations for async support, a new UI test button and automated test case in the sample app, and detailed documentation for iOS testing. Review feedback primarily identified several typos and capitalization issues in the C# documentation, the test app readme, and the release notes.
❌ Integration test FAILEDRequested by @firebase-workflow-trigger[bot] on commit 6c8819b
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Analytics: Add apple store kit 2 support for logging apple transactions.
Testing
Test locally with simulator and simulated Apple transaction:
Added in additional integration tests to validate the other platforms are error free.
Type of Change
Place an
xthe applicable box: