Skip to content

fix: increment build number for preview releases #10946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chkuang-g wants to merge 6 commits into
base: main
Choose a base branch
from
+16 −2
Open

fix: increment build number for preview releases #10946

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8aa8558
fix: append commit SHA to preview versions to avoid 403 Forbidden
chkuang-g Aug 18, 2026
f83859c
refactor: use incremental counter for preview versions
chkuang-g Aug 18, 2026
c597ee6
refactor: make preview version suffix extraction more robust
chkuang-g Aug 18, 2026
b448a91
refactor: pass jq variables using --arg instead of shell interpolation
chkuang-g Aug 18, 2026
8ed95ec
Merge branch 'main' into chkuang/fix-preview-publish
chkuang-g Aug 18, 2026
170a70b
Merge branch 'main' into chkuang/fix-preview-publish
chkuang-g Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions scripts/publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,22 @@ echo "Ran tests."
if [[ $VERSION == "preview" ]]; then
echo "Making a preview version..."
sanitized_branch=$(echo "$BRANCH" | sed 's/[^a-zA-Z0-9]/-/g')
npm version prerelease --preid=${sanitized_branch}
NEW_VERSION=$(jq -r ".version" package.json)
npm version prerelease --preid=${sanitized_branch} --no-git-tag-version
INITIAL_VERSION=$(jq -r ".version" package.json)
PREFIX=${INITIAL_VERSION%.*}
echo "Checking registry for existing preview versions with prefix ${PREFIX}..."
MATCHING_VERSIONS=$(npm view firebase-tools versions --registry https://wombat-dressing-room.appspot.com --json | jq -r --arg prefix "$PREFIX" 'if type == "array" then .[] else . end | select(startswith($prefix + "."))' || true)
if [[ -n "$MATCHING_VERSIONS" ]]; then
MAX_SUFFIX=$(echo "$MATCHING_VERSIONS" | sed 's/^.*\.//' | grep -E '^[0-9]+$' | sort -n | tail -n 1)
MAX_SUFFIX=${MAX_SUFFIX:-0}
NEXT_SUFFIX=$((MAX_SUFFIX + 1))
NEW_VERSION="${PREFIX}.${NEXT_SUFFIX}"
echo "Found existing preview versions. Bumping to ${NEW_VERSION}..."
npm version "${NEW_VERSION}" --no-git-tag-version --allow-same-version
else
NEW_VERSION=$INITIAL_VERSION
echo "No existing preview versions found. Using ${NEW_VERSION}."
fi
echo "Made a preview version."
else
echo "Making a $VERSION version..."
Expand Down
Loading