Skip to content

refactor(functions): use labeled "function" logs for kits - #10945

Merged
wandamora merged 1 commit into
mainfrom
morawand-kits-bullet-logs
Aug 18, 2026
Merged

refactor(functions): use labeled "function" logs for kits#10945
wandamora merged 1 commit into
mainfrom
morawand-kits-bullet-logs

Conversation

@wandamora

Copy link
Copy Markdown
Contributor

Description

Logs for kits should labeled with "functions" to follow CLI product conventions.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the logging in the functions:kits:install command to use the centralized labeled logging utilities (logLabeledWarning, logLabeledBullet, and logLabeledSuccess) from src/utils.ts instead of direct logger calls with manual color formatting. Additionally, the corresponding unit tests in functions-kits-install.spec.ts have been updated to verify that these labeled logs are correctly triggered. There are no review comments to address, and the changes look clean and align with the repository's best practices.

@shettyvarun268 shettyvarun268 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@wandamora
wandamora marked this pull request as ready for review August 18, 2026 00:50
Base automatically changed from morawand-kits-add-instances to main August 18, 2026 00:54
@wandamora
wandamora force-pushed the morawand-kits-bullet-logs branch from c413904 to 80816ef Compare August 18, 2026 01:11
@wandamora
wandamora enabled auto-merge (squash) August 18, 2026 01:14
@wandamora
wandamora merged commit 9411002 into main Aug 18, 2026
104 of 107 checks passed
@wandamora
wandamora deleted the morawand-kits-bullet-logs branch August 18, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants