-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Prototype Tool to Create Cloud Run Apps with Firebase CLI #10898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
falahat
wants to merge
24
commits into
main
Choose a base branch
from
bapi_prototype
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
21640d3
This is an ai-generated draft for testing. It must still be deeply re…
falahat 8ac398a
Address some initial comments and add E2E test suites in typescript
falahat 6d39157
Some follow-up fixes for env vars and secrets
falahat 472781b
Minor secret handling code, some debugging code as well
falahat 79e8bf7
Add soem ugly Cloud Build handling
falahat 913435c
Fix field masks for the v2 Cloud Run API
falahat 730fd65
Code review improvements:
falahat e8d689e
Followup fixes:
falahat 721e5bd
Fix firebase.json schema
falahat 89959de
Improve readability, extract helper methods, and address some code re…
falahat 90a2343
tighten up the API to require values explicitly. We pick defaults at …
falahat 8c325f1
Remove ABIU fields from firebase.json, these are only CLI flags. Clou…
falahat 899046a
Implement a placeholder init service
falahat 28af03f
Update some CLI flags
falahat 1d43d64
use polling instead of home-brewed manual waits when checking for Clo…
falahat 268b51d
fix polling
falahat eb1d28e
Add a temporary warning for BUILD secrets
falahat 97f4b5c
Dont need build secret warning
falahat bc669c1
clean uo gcp test resources
falahat 27664cd
Add a unit test for missing project id
falahat e966475
Format/lint fixes
falahat da5d61c
fix schema diff update
falahat e04aac1
Another pass of fixes from human code review
falahat e89b892
Add more secret tests
falahat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| #!/bin/bash | ||
|
falahat marked this conversation as resolved.
|
||
| set -e # Immediately exit on failure | ||
|
|
||
| # Globally link the CLI for the testing framework | ||
| ./scripts/clean-install.sh | ||
|
|
||
| if [ -f "scripts/set-default-credentials.sh" ]; then | ||
| source scripts/set-default-credentials.sh | ||
| fi | ||
|
|
||
| echo "======================================" | ||
| echo "Starting Cloud Run E2E Test Suite" | ||
| echo "======================================" | ||
|
|
||
| mocha scripts/run-deploy-tests/tests.ts --timeout 600000 | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.