Add crashlytics sdk setup guides to readmes - #10215
Conversation
|
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive setup guides and documentation for Firebase Crashlytics for Web Apps, covering frameworks like Angular, Next.js, React, and React Router, along with reusable documentation partials. The review feedback highlights several critical issues in the documentation examples: incorrect shell variable placeholders and unquoted JSON values in the main README, a misleading comment regarding log exclusion levels, a Next.js serialization runtime error caused by passing a non-serializable FirebaseApp instance in a Server Component layout, and a copy-pasted Next.js layout example in the standard React guide.
76e9cbc to
050b173
Compare
050b173 to
fa9bd33
Compare
PolinaGo
left a comment
There was a problem hiding this comment.
Reviewing files 1-by-1, starting with the top one
90b635e to
1662c3a
Compare
5addaa6 to
5d82cbc
Compare
5d82cbc to
b278c7f
Compare
📝 Overview of Changes & Review Feedback Addressed1. Project Configuration & Setup Flow
2. EAP Access & Prompt Updates
3. Framework-Specific Guides & Documentation Layout
|
05d1bde to
3ec5e1e
Compare
Preview: https://github.com/firebase/firebase-js-sdk/blob/crash-setup-docs/packages/crashlytics/README.md