Skip to content

Moves network request instrumentation initialization to a bg thread - #16920

Open
mghaznav wants to merge 2 commits into
firebase-crashlytics-telemetryfrom
ali/init-network-inst
Open

mghaznav wants to merge 2 commits into
firebase-crashlytics-telemetryfrom
ali/init-network-inst

Conversation

@mghaznav

Copy link
Copy Markdown
Contributor

Summary

Moves URLSessionInstrumentation initialization off the main thread onto a detached background task so the Objective-C runtime class scan does not block FirebaseApp.configure().

Changes

• Initialize URLSessionInstrumentation asynchronously on a background thread with ThreadHelper.isNotMainThread() verification.
• Capture self weakly in spanCustomization and make filterNetworkRequests static to avoid a retain cycle with URLSessionInstrumentation.
• Allow localhost network requests in filterNetworkRequests (only filtering out firebasetelemetry requests).
• Add unit tests in FirebaseCrashlyticsTelemetryTests.

@mghaznav mghaznav self-assigned this Oct 16, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@mghaznav

Copy link
Copy Markdown
Contributor Author

/gemini review

@danger-firebase-ios

Copy link
Copy Markdown
1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors FirebaseCrashlyticsTelemetry to initialize URLSessionInstrumentation on a background thread and adds thread-safety locks around shared resources. It also introduces unit tests for network request filtering and span customization. Feedback recommends optimizing the network request filter to avoid string allocations and safely handling potential nil values in both the filter and test teardown.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant