Repository navigation
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
Generated by 🚫 Danger |
There was a problem hiding this comment.
Code Review
This pull request refactors FirebaseCrashlyticsTelemetry to initialize URLSessionInstrumentation on a background thread and adds thread-safety locks around shared resources. It also introduces unit tests for network request filtering and span customization. Feedback recommends optimizing the network request filter to avoid string allocations and safely handling potential nil values in both the filter and test teardown.
Summary
Moves
URLSessionInstrumentationinitialization off the main thread onto a detached background task so the Objective-C runtime class scan does not blockFirebaseApp.configure().Changes
• Initialize
URLSessionInstrumentationasynchronously on a background thread withThreadHelper.isNotMainThread()verification.• Capture self weakly in
spanCustomizationand makefilterNetworkRequestsstatic to avoid a retain cycle withURLSessionInstrumentation.• Allow localhost network requests in filterNetworkRequests (only filtering out firebasetelemetry requests).
• Add unit tests in FirebaseCrashlyticsTelemetryTests.