Skip to content

fix(ci): skip dynamic workflows in nightly report generation - #16912

Merged
paulb777 merged 2 commits into
mainfrom
pb-nightly-report-dynamic-workflows
Oct 15, 2026
Merged

paulb777 merged 2 commits into
mainfrom
pb-nightly-report-dynamic-workflows

Conversation

@paulb777

Copy link
Copy Markdown
Member

Summary

infra.generate_issues has failed every night since Oct 10 (first failure), so no nightly testing report has been posted. On Oct 9, GitHub registered a GitHub-managed "Dependency Graph" workflow (dynamic/dependabot/update-graph) on the repo. The report looks up the scheduled runs of each workflow by file name, which 404s for dynamic workflows, and the uncaught Octokit::NotFound aborted the script before it posted the report. This is the same failure that earlier led to excluding codeql and dependabot-updates.

Changes

  • Skip dynamic workflows. app.rb now skips every workflow whose path starts with dynamic/, instead of excluding them one at a time. These only run on dynamic events: all 156 recent runs of the three current ones (CodeQL, Dependabot Updates, Dependency Graph) are dynamic, never schedule, so they couldn't appear in the report anyway.
  • Don't abort on a failed lookup. A failed lookup of workflow runs (Octokit::Error or Faraday::Error) is now a row in the report, e.g. error fetching runs (Octokit::BadGateway), instead of aborting the script. The Oct 12 run failed this way, on a transient 502 for sdk.core.extension.yml. The row shows only the error class; the full message goes to the job log.
  • Exclusions. Exclude sdk.performance.integration.yml and sdk.sessions.integration.yml. The old performance-integration-tests.yml and sessions-integration-tests.yml entries no longer matched anything, so both workflows were showing up in the report. Drop codeql and dependabot-updates, which are now skipped as dynamic workflows.

Testing

Ran app.rb locally against the live API with the scheduled job's inputs, using Ruby 3.4.1 and the locked gems as in the action's Dockerfile. Issue creation, comments, and closing were stubbed out, and all other writes were blocked.

  • The script on main fails with the same update-graph 404 as CI.
  • With this change, it processes all 86 workflows: the 3 dynamic workflows are skipped and the 2 integration workflows are excluded. It also hit a real transient 500 for prerelease.yml, which became a row in the report instead of aborting.
  • Injecting Octokit::BadGateway and Faraday::TimeoutError for two workflows adds two error rows, and the report is still posted.

The test_generate_an_issue job on this PR runs the action end to end.

After this lands, the next nightly run will open a new nightly-testing issue, since the last one is closed.

#no-changelog

The nightly testing report has failed every night since Oct 10, when
GitHub registered the GitHub-managed "Dependency Graph" workflow
(dynamic/dependabot/update-graph) on the repo. The report looked up the
scheduled runs of each workflow by file name, which 404s for dynamic
workflows, and the uncaught Octokit::NotFound aborted the script before
it posted the report.

Skip all dynamic/ workflows, which only run on dynamic events and never
on schedule, instead of excluding them one at a time. Also record a
failed lookup of workflow runs (e.g. a transient 5xx or a timeout) as a
row in the report instead of aborting, so one bad request cannot block
the whole report.

Exclude sdk.performance.integration.yml and
sdk.sessions.integration.yml, replacing the stale pre-rename names that
no longer matched anything, and drop the now-redundant codeql and
dependabot-updates entries.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@paulb777

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the testing report generation script to skip GitHub-managed dynamic workflows (starting with 'dynamic/') and wraps the workflow runs fetch operation in a rescue block to handle Octokit and Faraday errors gracefully. Feedback suggests using idiomatic Ruby string interpolation instead of string concatenation and logging the full workflow path for better context.

Comment thread .github/actions/testing_report_generation/app.rb Outdated
Print the full workflow path (e.g. dynamic/dependabot/update-graph)
instead of the basename, since the dynamic/ prefix is why the workflow
is skipped, and use string interpolation instead of concatenation.

@ncooke3 ncooke3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@paulb777
paulb777 merged commit 9a65636 into main Oct 15, 2026
32 checks passed
@paulb777
paulb777 deleted the pb-nightly-report-dynamic-workflows branch October 15, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants