[dajiaohuang]

Summary

• Hash children in Firebase priority order whenever at least one child has a priority, matching the Realtime Database transaction hash algorithm.
• Cover a node where every child has a priority and priority order differs from key order; document the transaction maxretry effect under Unreleased with fix(database): hash prioritized children in priority order #16769.

Validation

• Changed files pass clang-format 23.1.2 and git diff --check.
• At exact source df437c8, the actual upstream Catalyst Database unit suite executes 430 tests with zero failures, explicitly including testChildrenNodeHashUsesPriorityOrderWhenEveryChildHasPriority: native XCTest log.
• The separate quickstart dependency conflict remains a broader workflow failure; it does not invalidate the inspected unit result or establish complete workflow acceptance.

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

[paulb777]

Agent claims the existing behavior is inconsistent with Android and Web

[paulb777]

Thanks for the contribution! A few housekeeping items:

• CHANGELOG: The entry in FirebaseDatabase/CHANGELOG.md is under # 12.19.0, which has already shipped. Please move it under a # Unreleased heading at the top of the file (add the heading if it isn't there yet).
• PR number: end the entry with this PR's number, e.g. - [fixed] Description. (#16769).
• Formatting: after updating, please run scripts/style.sh so the infra.check job passes. It needs clang-format 23 and swiftformat (see scripts/setup_check.sh). If you can't run it locally, the infra.check log lists the files that need formatting.

[paulb777]

/gemini review

[gemini-code-assist]

Code Review

This pull request fixes the node hashing logic in FChildrenNode.m to correctly use priority order when all children have priorities, by ensuring the check for non-empty priorities is properly negated. A corresponding unit test has been added to verify this behavior. The reviewer suggested a minor improvement to the loop in FChildrenNode.m to use an explicit if statement for better readability and to avoid redundant boolean assignments.

[paulb777]

Thanks, nice catch. Because the check is inverted, a node whose children all have priorities is hashed in key order instead of priority order. That doesn't match the server, or the Android and JS SDKs. The hash is sent with transactions and listens, so transactions on such data can fail with maxretry, and listens re-download data the client already has. The one-character fix matches Android's ChildrenNode.getHashRepresentation.

Optional CHANGELOG wording: - [fixed] Fixed an issue where transactions could fail with a maxretry error when every child of a node had a priority. (#16769)

[dajiaohuang]

Added the literal JS-algorithm golden ioxrlJO1lx052It4dFes/dAFe9Y= alongside the existing ordering assertion. Independently recomputing the SHA-1/IEEE-754 leaf representations also yields that priority-order value and ngiLaZ8GVGzsDXgauGE/6t0CDuA= for key order. This calculation is not an execution of the iOS or JS SDK tests.

Moved the changelog to Unreleased/#16769 using the suggested maxretry wording. Changed Objective-C files were formatted with clang-format 23.1.2 and git diff --check passes. Native Apple XCTest remains unrun locally and requires current-head CI.

[paulb777]

/gemini review

[gemini-code-assist]

Code Review

This pull request fixes an issue where transactions could fail with a maxretry error when every child of a node has a priority. The fix corrects the logic in FChildrenNode.m to ensure sawPriority is set to true when a child node's priority is not empty. A corresponding unit test has been added to verify that the children node hash correctly uses priority order. There are no review comments, and I have no feedback to provide.

[ncooke3]

Thanks!