refactor(common): use FirebaseEnv for parameter resolution#223
Open
Yusufihsangorgel wants to merge 1 commit into
Open
refactor(common): use FirebaseEnv for parameter resolution#223Yusufihsangorgel wants to merge 1 commit into
Yusufihsangorgel wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors parameter resolution in lib/src/common/params.dart to use FirebaseEnv instead of directly accessing Platform.environment. This decouples the environment variable lookup and allows for easier mocking. Corresponding unit tests have been added in test/unit/params_test.dart to verify parameter resolution with mocked environments. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FirebaseEnvListParamandEnumListParamalready use this interface. Moving theremaining parameter classes to the same seam keeps production resolution
unchanged while making their runtime and deployment paths unit-testable with
FirebaseEnv.mockEnvironment.Fixes #221.
Testing
dart test test/unitdart analyze --fatal-infos lib/src/common/params.dart test/unit/params_test.dartdart format --output=none --set-exit-if-changed .