[ONB-2514] Feat(v2): Add legal representative document upload#27
Merged
Conversation
Adds upload_legal_representative_document to the onboardings manager, PUTting a multipart file to the legal representative document slot path, and exposes the new legal_representatives array on the Onboarding resource. Create params move to the plural legal_representatives array the API now expects.
Documents the legal_representatives attribute on the onboarding full shape and the upload_legal_representative_document usage, and updates the create example to the plural legal_representatives array the API now expects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
La API pública v2 ahora soporta múltiples representantes legales por onboarding, cada uno con sus propios slots de documentos (
identificationypower_of_attorney). El SDK necesita exponer la subida de esos documentos.Qué hay de nuevo?
PUT /v2/entities/{entity_id}/onboardings/{id}/legal_representatives/{legal_representative_id}/documents/{slot_key}Fintoc::V2::Onboardingahora exponelegal_representatives(la API lo devuelve como array a nivel del onboarding, hermano deshareholdersydocuments).legal_representativescomo array (el shape singularlegal_representativeya no existe en la API) y se documenta la subida de documentos del representante legal.Tests
Unitarios para el manager (path, multipart e idempotency_key) y para el recurso (round-trip de
legal_representatives), espejando la cobertura existente de shareholders.Rollback
¿Es seguro hacer rollback?
Sí
¿Cuáles son los pasos para hacer rollback?
Normal