[ONB-2512] Feat(v2): Add legal representative document upload#102
Merged
Merged
Conversation
uploadLegalRepresentativeDocument PUTs the file to /v2/entities/{entity_id}/onboardings/{id}/legal_representatives/{legal_representative_id}/documents/{slot_key}, mirroring the shareholder document upload. Adds the OnboardingLegalRepresentative resource for the legal_representatives array now present in onboarding responses, and updates the create() example to the new legal_representatives array form (the singular legal_representative object is gone from the API).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the new v2 legal representative document upload endpoint:
PUT /v2/entities/{entity_id}/onboardings/{onboarding_id}/legal_representatives/{legal_representative_id}/documents/{slot_key}Also adds the
OnboardingLegalRepresentativeresource class for thelegal_representativesarray that the API now returns on the onboarding object, mirroring howOnboardingShareholderis modeled.Requirements
None.
Additional changes
The onboarding create integration test now sends
legal_representativesas an array, matching the API's current request shape (the singularlegal_representativeobject no longer exists).