[TRNF-7286] Feat(v2): Add entity onboardings and multipart uploads by JoMarchant · Pull Request #100 · fintoc-com/fintoc-node

JoMarchant · 2026-06-22T17:03:29Z

Contexto

Soporte en el SDK para el nuevo flujo de onboarding de entities de la API pública v2 (/v2/entities/{id}/onboardings).

Qué hay de nuevo?

Se exponen los siguientes endpoints para el proceso de onboarding de entities:
- POST /v2/entities
- POST /v2/entities/{id}/onboardings
- PUT /v2/entities/{id}/onboardings/{id}/shareholders/{id}/document
- PUT /v2/entities/{id}/onboardings/{id}/documents/{slot_key}
- POST /v2/entities/{id}/onboardings/{id}/submit
Se agrega soporte de multipart/form-data en el cliente HTTP.

Tests

Unitarios para el cliente multipart, los recursos y el manager (incluyendo las subidas de documentos). Probado end-to-end localmente contra fintoc-rails + pacioli (crear onboarding → subir documentos → submit).

Consideraciones

Las subidas multipart no se firman con JWS.

Rollback

¿Es seguro hacer rollback?
Sí

¿Cuáles son los pasos para hacer rollback?
Normal

Add a `form` request option and a `resourceUpload` handler so managers can send multipart bodies via FormData, letting form-data set the Content-Type boundary. JWS signing is skipped for multipart requests. Declares the form-data dependency explicitly.

Onboarding, OnboardingShareholder and OnboardingDocument resources for the v2 entity onboarding response.

Onboardings are nested under entities (fintoc.v2.entities.onboardings), mirroring account_statements: list, get, create, submit, and slot + shareholder document uploads (via resourceUpload, errors mapped to typed Fintoc errors). Also enables fintoc.v2.entities.create.

tlarrain

Dejé comms y dudas

tlarrain · 2026-06-22T20:38:05Z

+  });
+  const data = await client.request({ path, method: 'put', form });
+  return objetize(
+    klass,


que sea con k es a propósito? jajaja

Seguí el patrón que estaba en las otras clases nomás jeje, según yo igual es común para evitar el clash con class que es un keyword

tlarrain · 2026-06-22T20:39:59Z

    const innerParams = Object.fromEntries(query.map((x) => x.split('=')));
    const completeParams = { ...innerParams, ...(params === undefined ? {} : params) };
    const usableURL = url?.split('//').slice(-1)[0].split('/').slice(1).join('/').split('?')[0] || '';
+    const isMultipart = data !== undefined && typeof data !== 'string';


esta es la forma real de definir si algo es multipart? si es una imagen esto también sería true y no necesariamente sería multipart

damn, no se me ocurrió

voy a ver otra forma

tlarrain · 2026-06-22T20:41:24Z

@@ -1,4 +1,5 @@
 import { Method } from 'axios';
+import FormData from 'form-data';


necesitamos esta librería? creo que usar el soporte nativo de Javascript sería mejor opción

pucha si, estamos con node-10 como min requirement del SDK

tlarrain · 2026-06-22T20:42:38Z

+    return this.uploadFile(path, file);
+  }
+
+  @canRaiseHTTPError


este necesita esto vs los otros por alguna razón específica?

con el refactor queda gucci

tlarrain · 2026-06-22T20:45:00Z

+    const klass = await getResourceClass(
+      (this.constructor as typeof OnboardingsManager).resource,
+    );
+    return resourceUpload<Onboarding>(this._client, path, klass, file);


no estoy seguro como se podría hacer, pero me tinca que uno podría extender el manager y que esto sea un método miembro de la clase, para poder hacer this.uploadResource(path, klass, file). Creo que quedaría más nice de ser posible. Si se enreda mucho la cosa lo podemos dejar así. Siento que pasarle el this._client es medio hacky y se podría evitar

Voy con esto, es un buen refactor

JoMarchant · 2026-06-22T21:14:26Z

@tlarrain moví el upload a manager mixin y ahora valido el tipo de data para ver si es form

tlarrain

Quedó mucho más nice, congrats!

JoMarchant self-assigned this Jun 22, 2026

JoMarchant force-pushed the feat/entities-onboarding branch 4 times, most recently from 2a7e94f to 5a5f717 Compare June 22, 2026 20:07

JoMarchant added 3 commits June 22, 2026 16:29

feat(v2): add onboarding resource types

c1442b3

Onboarding, OnboardingShareholder and OnboardingDocument resources for the v2 entity onboarding response.

JoMarchant force-pushed the feat/entities-onboarding branch from 5a5f717 to a83c195 Compare June 22, 2026 20:29

JoMarchant marked this pull request as ready for review June 22, 2026 20:34

JoMarchant requested review from tlarrain and vacodoceo June 22, 2026 20:35

tlarrain reviewed Jun 22, 2026

View reviewed changes

JoMarchant added 2 commits June 22, 2026 17:10

fixup! feat(client): support multipart/form-data uploads

2c6eb58

fixup! feat(v2): add onboardings manager and expose entity creation

f1c8558

JoMarchant requested a review from tlarrain June 22, 2026 21:13

JoMarchant changed the title ~~Feat(v2): Add entity onboardings and multipart uploads~~ [TRNF-7286] Feat(v2): Add entity onboardings and multipart uploads Jun 22, 2026

tlarrain approved these changes Jun 22, 2026

View reviewed changes

JoMarchant merged commit b6b7223 into master Jun 23, 2026
2 checks passed

		@@ -1,4 +1,5 @@
		import { Method } from 'axios';
		import FormData from 'form-data';

Uh oh!

Conversation

JoMarchant commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contexto

Qué hay de nuevo?

Tests

Consideraciones

Rollback

Uh oh!

tlarrain left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JoMarchant commented Jun 22, 2026

Uh oh!

tlarrain left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JoMarchant commented Jun 22, 2026 •

edited

Loading