[ONB-2057] Wire browser flow into login command#50
Merged
Conversation
15c9c50 to
d1a8805
Compare
daleal
approved these changes
Jun 2, 2026
daleal
left a comment
Member
There was a problem hiding this comment.
Lo veo bien, dejo sugerencias menores
daleal
reviewed
Jun 2, 2026
d1a8805 to
32fb930
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
Ya teníamos la librería
browser-loginlista del PR anterior. Faltaba conectarla al comandologiny dejar la metadata de la key visible enconfig.Que hay de nuevo?
loginahora abre el browser para autenticar, con paste manual como fallback si el usuario prefiere pegar la key mientras espera--mode test|live(default test) y-y/--yespara skipear la confirmación de re-loginconfigmuestrakey_nameyexpires_atcuando la key viene del archivo, tanto en texto como en--jsonFintocConfigextendido conkey_name?yexpires_at?, yresolveAuthlos propagaUX
fintoc login: abre el browser en modo test, muestra el link por si no abre solo y queda esperando el callback. En paralelo acepta paste manual, gana el primero.fintoc login --mode live: igual pero en modo live, además persistekey_nameyexpires_at.fintoc logincon sesión activa: pide confirmación antes de continuar. Con--yesla skipea.fintoc login --api-key sk_...: salta el browser y guarda la key directo (también es el camino para CI/non-TTY).Tests
Created with Claude Code
/create-prcommand