docs: unify repo and website docs#1487
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1487 +/- ##
=======================================
Coverage 90.28% 90.28%
=======================================
Files 69 69
Lines 5558 5558
Branches 956 956
=======================================
Hits 5018 5018
Misses 521 521
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9d5cf44 to
8bd81b8
Compare
|
@finos/git-proxy-maintainers Would appreciate another look here! |
|
Conflicts and a few minor URL corrections to do here @jescalada otherwise I think this ready to merge |
|
@kriswest Ready for another look! |
kriswest
left a comment
There was a problem hiding this comment.
This is probably good to go - but a rebase onto main followed by checking docs/Releases.md is moved to /website is necessary
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
fed04e7 to
17df663
Compare
Accidentally brought these changes in while rebasing - they're being added in finos#1511 instead
|
One thing to note is that the live docs aren't updating despite the preview being freshly generated... (Tracked in #1534) @finos-admin Wondering if we have any issues on our Netlify deploy? |
Fixes #1407.
Also pins the
lodashwebsite dependency to fix a CI failure from this advisory, which is necessary asdocusaurusnever seems to fix their dep vulnerabilities...Preview link: https://deploy-preview-1487.git-proxy.preview.finos.org/