Skip to content

feat: add TLS support to API/UI service#1414

Merged
jescalada merged 20 commits into
finos:mainfrom
fabiovincenzi:feat/tls-ui-api-server
May 14, 2026
Merged

feat: add TLS support to API/UI service#1414
jescalada merged 20 commits into
finos:mainfrom
fabiovincenzi:feat/tls-ui-api-server

Conversation

@fabiovincenzi
Copy link
Copy Markdown
Contributor

Fixes #1408
Add HTTPS on port 8444 (configurable via GIT_PROXY_HTTPS_UI_PORT) to the API/UI service, using the existing tls.enabled/key/cert config fields already used by the proxy. HTTP and HTTPS run in parallel.

@fabiovincenzi fabiovincenzi requested a review from a team as a code owner February 23, 2026 10:56
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 23, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit e02b146
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6a054303b4e69c000821d804

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 90.32258% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.28%. Comparing base (ad58c5a) to head (e02b146).

Files with missing lines Patch % Lines
src/service/index.ts 90.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1414      +/-   ##
==========================================
+ Coverage   90.21%   90.28%   +0.06%     
==========================================
  Files          69       69              
  Lines        5511     5558      +47     
  Branches      944      956      +12     
==========================================
+ Hits         4972     5018      +46     
  Misses        521      521              
- Partials       18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM, might want another look from @kriswest to make sure.

Comment thread src/service/index.ts
@kriswest
Copy link
Copy Markdown
Contributor

@fabiovincenzi (note from meeting) it would be great to get this covered in the Config reference and getting started guide before its merged.

@kriswest kriswest modified the milestone: 2.1.0 Apr 20, 2026
@kriswest kriswest requested a review from a team April 20, 2026 16:00
@kriswest kriswest removed this from the 2.1.0 milestone Apr 20, 2026
Copy link
Copy Markdown
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should be good to ship in 2.1 👍🏼

@jescalada jescalada merged commit e0d7b0f into finos:main May 14, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable TLS for UI and API

3 participants