Refactor color(opacity:) to improve performance#155
Merged
finnvoor merged 1 commit intoJan 31, 2026
Merged
Conversation
alicerunsonfedora
changed the title
Per my discoveries with Renzo when improving the performance of the scene renderer, I leanred that I could make my Graphics.Color.dithered(by:) method faster by moving the Bayer pattern out as a constant, and initialzing the UInt8 array via the literal instead of the Array(repeating:count:) initializer. These changes are incredibly helpful if this color(opacity:) method is being called in rather hot loops where performance is critical.
alicerunsonfedora
force-pushed
the
marquis/color-dithered-performance-update
branch
from
97273d2 to
63baea8
Compare
Owner
|
looks good, thanks! |
alicerunsonfedora
deleted the
marquis/color-dithered-performance-update
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per my discoveries with Renzo when improving the performance of the scene renderer, I learned that I could make my
Graphics.Color.dithered(by:)method faster by moving the Bayer pattern out as a constant, and initializing theUInt8array via the literal instead of theArray(repeating:count:)initializer.These changes are incredibly helpful if this color(opacity:) method is being called in rather hot loops where performance is critical.
Feel free to also reference what I've done in Renzo: https://source.marquiskurt.net/PDUniverse/Renzo/commit/59b0de3355b52940f18c13a696b6f332a366d08b