Repository navigation
Configure pytest to fail on what it should fail on - #2
Merged
Merged
Conversation
py-canon 1.3.0 puts the whole sp-repo-review PP301-PP309 set in the template: minversion, log_level, xfail_strict, filterwarnings = ["error"], and -ra/--strict-config/--strict-markers in addopts. These decide whether a run *fails* rather than how it reads. Without filterwarnings a dependency's DeprecationWarning stays invisible until the release that removes the API; without --strict-markers a typo in a marker name selects nothing and reports success; without --strict-config a typo in this very table is ignored. Applied with `preen fix pytest-config`, and the suite was run under the new settings before this was opened -- the point of the change is that warnings now fail, so a config that quietly breaks the suite would defeat it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011SkMDqnEFUgr7Mbc1HwMqX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
py-canon 1.3.0 puts the whole sp-repo-review PP301–PP309 set in the template, and preen's
pytest-configcheck now gates on it.These decide whether a run fails, not how it reads. Without
filterwarningsa dependency's DeprecationWarning stays invisible until the release that removes the API; without--strict-markersa typo in a marker name selects nothing and reports success; without--strict-configa typo in this very table is ignored.Applied with
preen fix pytest-config. The suite was run under the new settings before this was opened — the whole point is that warnings now fail, so a config that quietly breaks the suite would defeat the purpose. Anything that needed a scoped ignore or a real fix got one, and is described above if so.🤖 Generated with Claude Code