Conversation
…-click test - Guard against Windows pytest-current symlink PermissionError during sessionfinish cleanup - Cleanly teardown top-level Qt widgets in tests/conftest.py to avoid dangling QObjects at exit - Explicitly close and schedule deleteLater() in test_checksum_dialog_close_cancels_worker - Add regression test for right-click on unselected row selecting the row before context menu actions - Fixes T-20260928-295547351
|
Welcome! Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing. |
lukisch
commented
Oct 3, 2026
lukisch
left a comment
Collaborator
Author
There was a problem hiding this comment.
Zweitmodell-Review: CI grün (13/13 Checks), keine Blocker.
Umfang: nur Tests/Teardown (tests/conftest.py, zwei Testdateien). Keine Credentials, keine Nutzerpfade.
Hinweise:
conftest.pyersetzt die privaten pytest-Funktionen_pytest.pathlib.cleanup_dead_symlinksundcleanup_numbered_dirper Monkeypatch. Ändert pytest die Signatur, schlägt das erst beim Teardown alsTypeErrorfehl (gefangen werden nurOSErrorbeim Aufruf undImportError/AttributeErrorbeim Import). Mitpytest>=9.1.1aktuell grün; ein Kommentar mit dem getesteten pytest-Bereich wäre sinnvoll.- Merge-Konflikt-Risiko:
tests/conftest.pywird auch von #14, #15 und #17 neu angelegt (jeweils mit anderem Inhalt, hier 80 Zeilen, dort 25 bis 29). Nach dem ersten Merge brauchen die übrigen ein Rebase. Empfehlung: diese Variante zuerst mergen und die anderen darauf rebasen.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
T-20260928-295547351
Problem & Ursache
Loesung
Verifikation
uff check .: 0 Fehler.