Feature solver - #26
Open
rbaral wants to merge 2 commits into
Open
Conversation
Contributor
|
LGTM! |
wddcheng
approved these changes
Sep 9, 2026
skadio
approved these changes
Sep 9, 2026
skadio
left a comment
Contributor
There was a problem hiding this comment.
Checking if this approval works/possible.
Contributor
|
(let me know if you need help in updating pypi) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
This PR provides the solution to the issue Linear Selection Method fails with Python 3.12 (#24). The issue is about the Linear selection failing because the scikit-learn does not support
multi_classattribute for LogisticRegressionSee more context and replication steps at #24
Fix:
__init__()method, use the OneVsRestClassifier to wrap the LogisticRegression and remove the multi_class attribute.process_category_data()method@takojunior @kuppulur @skadio @wddcheng Can you please help with the PR review?