Conversation
This change will update the entra-id protocol to check for group overage regardlless of how the role ARN was provided. This should now return the same error message when a user supplies the AWS IAM role ARN through the --role-arn flag, or when a user selects the AWS IAM role through prompts. Signed-off-by: Rob Casale <rcasale48@verizon.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change will update the
entra-idprotocol to check for group overage regardlless of how the role ARN was provided.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # This should now return the same error message when a user supplies the AWS IAM role ARN through the --role-arn flag, or when a user selects the AWS IAM role through prompts.
Testing
make ciandmake lintcompleted successfully.Example error message that the user will see:
This branch can be deleted once it is merged.