feat: add assume-role-arn flag for Entra ID - #915
Merged
Gearheads merged 2 commits intoSep 18, 2026
Merged
Conversation
Signed-off-by: Casale, Robert <robert.casale@fmr.com>
…to v2.13.2 This change will fix the make lint instruction by upgrading github.com/golangci/golangci-lint/v2 from v2.12.2 to v2.13.2, and fix the ambiguous import message from go mod tidy caused by the monolithic dependency google.golang.org/genproto. Signed-off-by: Casale, Robert <robert.casale@fmr.com>
kishoregv
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR will add the
--assume-role-arnflag to the Entra ID protocol for the EKS provider to allow users to assume another AWS IAM role in another AWS account.This is required by some teams that use a global AWS IAM role to reduce the number of AD groups required.
This PR also includes a couple improvements:
make lintinstruction is fixed by upgradinggithub.com/golangci/golangci-lint/v2fromv2.12.2tov2.13.2, and resolving out dated dependenciesWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # Users not able to assume an AWS IAM role with the Entra ID protocol, similarly like they do with the SAML protocol.
Testing
I was able to build kconnect locally, and test the
--assume-role-arnflag for Entra ID successfully:Also, I checked that
make lintworks as expected now:This branch can be deleted once it is merged.