Skip to content

feat: default min_frac_accessible to 0.10 #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrvollger merged 1 commit into from
Aug 14, 2026
Merged

feat: default min_frac_accessible to 0.10 #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ Forgo the use of FDR peak calling and instead call peaks for regions with at lea
```
min_per_acc_peak = 0.25
```
Apply a percent actuation filter on top of the FDR peak calling. Default is `0.0` for no filter.
Apply a percent actuation filter on top of the FDR peak calling. Default is `0.10`; set to `0.0` for no filter.
```
min_frac_accessible: 0.0
min_frac_accessible: 0.10
```
Process only chromosomes matching this regular expression:
```
Expand Down
2 changes: 1 addition & 1 deletion workflow/Snakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ if MIN_PER_ACC_PEAK is None:
MIN_PER_ACC_PEAK = 0.0
else:
MAX_PEAK_FDR = 1.0
MIN_FRAC_ACCESSIBLE = config.get("min_frac_accessible", 0)
MIN_FRAC_ACCESSIBLE = config.get("min_frac_accessible", 0.10)

# data filtering
FILTER_FLAG = config.get("samtools-filter-flag", "260") # 2308
Expand Down
Loading