Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using subcommands like
cloudctl postgres edit ..all camelcased yaml fields were converted to lowercase. This was consistent insofar as this worked in both directions. However,cloudctl postgres describe -o yaml ..produced camelcased yaml output, which one could not copy/paste into an edit session because the marshaller expected lower case yaml fields.This PR proposes to use
sigs.k8s.io/yamlfor the edit subcommands. This yaml module converts to JSON before converting that to Yaml and due to the JSON-tags on our structs camelcase will be preserved this way.In order for this to work, I also had to modify
helpers.ReadFrom(). Sincesigs.k8s.io/yamlhas noDecoderI had to change it so, that it splits the input into separate yaml documents directly usingbufio.Scannerandbytes.Split().