Conversation
majst01
commented
Sep 10, 2026
| // StageTypeTitle string `json:"stage_type_title"` | ||
| // StageTypeUuid *openapi_types.UUID `json:"stage_type_uuid,omitempty"` | ||
| // } | ||
| string title = 2 [(buf.validate.field).string.(fits.api.v1.is_name) = true]; |
Contributor
Author
There was a problem hiding this comment.
maybe always name for names ?
vknabel
reviewed
Sep 24, 2026
vknabel
reviewed
Sep 24, 2026
Comment on lines
+230
to
+233
| // Status of the ongoing operation. | ||
| // TODO: can we have an ENUM here? Active, Are deleted ones there? Are stopped ones accounted? | ||
| // Would have to be part of openapi spec, otherwise breaking changes couldn't be detected | ||
| string status = 12; |
Contributor
There was a problem hiding this comment.
I think you can prepare an enum here. This field does not serve any purpose if the UI cannot automatically react on this.
vknabel
reviewed
Sep 24, 2026
vknabel
reviewed
Sep 24, 2026
Comment on lines
+51
to
+57
| // Changes the size or auto-extend behavior of an existing disk; see | ||
| // DiskType for which operations apply per disk kind. | ||
| rpc UpdateDisk(MVMServiceUpdateDiskRequest) returns (MVMServiceUpdateDiskResponse) { | ||
| option (fits.api.v1.project_roles) = PROJECT_ROLE_OWNER; | ||
| option (fits.api.v1.project_roles) = PROJECT_ROLE_EDITOR; | ||
| option (fits.api.v1.auditing) = AUDITING_INCLUDED; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| // Changes the size or auto-extend behavior of an existing disk; see | |
| // DiskType for which operations apply per disk kind. | |
| rpc UpdateDisk(MVMServiceUpdateDiskRequest) returns (MVMServiceUpdateDiskResponse) { | |
| option (fits.api.v1.project_roles) = PROJECT_ROLE_OWNER; | |
| option (fits.api.v1.project_roles) = PROJECT_ROLE_EDITOR; | |
| option (fits.api.v1.auditing) = AUDITING_INCLUDED; | |
| } |
To be discussed. Should not block this PR.
ma-hartma
marked this pull request as ready for review
September 25, 2026 15:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds VM Instance Types to define contracts.
Already implemented:
Needs #13
Supported by Qwen 3.8