fix(parser): numeric filehandle diamond \<N\> (Acme::Buffy, open 0)#734
Merged
Conversation
Perl lexes `<0>` as NUMBER not IDENTIFIER, so the diamond parser fell through to quote-like parsing and produced the string "0". That broke Acme::Buffy (and any `open 0; ... <0>` idiom): the script body was never read. Treat all-digit glob names (e.g. main::0) as bareword handles and handle `<digits>` in parseDiamondOperator. Generated with [Cursor](https://cursor.com/docs) Co-Authored-By: Cursor <noreply@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parse
<digits>in the diamond / readline position as readline on the numeric typeglob (*0,*1, …), not as a quote-like string. The lexer emitsNUMBERfor0, so<0>previously fell through toparseRawStringand became the one-character string"0", which broke anyopen 0; ... <0>pattern (notably Acme::Buffy).In
parseBarewordHandle, treat all-digit glob names (e.g.main::0) as valid bareword handles so<0>matches Perl’sopen 0/$0script-read idiom without requiring a priorexistsGlobalIOentry.Test plan
make(unit tests)timeout 600 ./jcpan -t Acme::Buffy— passes (t/buffy.t)jperl -e 'open 0; print length join "", <0>'on a script file matches reading full source lengthMade with Cursor