Fix: suppress handled chat agent max-turn Sentry events#326
Merged
Conversation
Member
Author
|
STAFF ENGINEER REVIEW: APPROVED — clean structural review. Checked Sentry suppression scope, chat-agent context lifetime, Agents SDK call sites, secret patterns, and targeted regressions. Codex review found no discrete regression. Local verification: |
Member
Author
|
✅ Approved + merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FFM-1764.
Summary
agents.exceptions.MaxTurnsExceededevents from the chat-agent path even when Sentry reports them withlogger=null/mechanism=openai_agents.Verification
python3 -m pytest tests/test_sentry_observability.py -qruff check --fix src/ tests/ && ruff format src/ tests/Notes
agents.exceptionsdependency and Docker is unavailable here, sotests/tgbot/test_chat_agent_runner.pycould not be collected locally. CI should run it in the app dependency environment.