Disable inline share canary by default#324
Merged
Merged
Conversation
Member
Author
|
STAFF ENGINEER REVIEW: APPROVED — No structural issues found. Scope is limited to changing |
Member
Author
|
✅ Approved + merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TELEGRAM_INLINE_SHARE_CANARY_PERCENTdefault to0so future deployments do not expose new exact-meme inline share assignments unless explicitly re-enabled.url_sharewhen the canary percent is zero.Production action
TELEGRAM_INLINE_SHARE_CANARY_PERCENT=0to the Coolifyffmemes-backendapplication env.3c3ce301so the running app reloads the env setting.Verification
ruff check --fix src/ tests/ruff format src/ tests/DATABASE_URL='postgresql+asyncpg://postgres:postgres@localhost/postgres' REDIS_URL='redis://localhost:6379/0' CORS_ORIGINS='[]' CORS_HEADERS='[]' TELEGRAM_BOT_USERNAME='ffmemesbot' python3 -m pytest tests/tgbot/test_sharing.py -qFixes FFM-1745.