Skip to content

Fix: harden QA monitoring smoke docs#323

Merged
ohld merged 1 commit into
productionfrom
fix/ffm-1708-qa-smoke-sentry
Jun 23, 2026
Merged

Fix: harden QA monitoring smoke docs#323
ohld merged 1 commit into
productionfrom
fix/ffm-1708-qa-smoke-sentry

Conversation

@ohld

@ohld ohld commented Jun 23, 2026

Copy link
Copy Markdown
Member

Refs FFM-1708.

What changed

  • Correct QA/runbook Sentry scan commands to match the installed sentry issues list CLI syntax.
  • Keep the existing e2e smoke URL-button guard covered with focused regression tests, including URL-only markup and mixed URL/callback keyboards.

Verification

  • ruff check --fix src/ tests/
  • ruff format src/ tests/
  • git diff --check
  • python3 -m pytest tests/scripts/test_e2e_smoke.py

Remaining operational action

  • sentry issues list --query "is:unresolved" --max-rows 3 still reaches Sentry but returns 401 Invalid token in the CTO runtime too. The Paperclip secret metadata endpoint returns 403 Board access required for this run, so SENTRY_AUTH_TOKEN must be rotated by an owner with Paperclip/Sentry secret access before QA scans are fully restored.

@ohld

ohld commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

STAFF ENGINEER REVIEW: APPROVED — Staff Engineer review: approved. Scope is limited to Sentry CLI runbook/QA-agent command corrections plus focused e2e smoke regression coverage for URL-only and mixed URL/callback inline keyboards.

Review checks:

  • /review structural pass: no issues found
  • /codex review: no discrete bug found
  • Verified installed sentry issues list --query "is:unresolved" --max-rows 20 help supports the documented flags
  • python3 -m pytest tests/scripts/test_e2e_smoke.py passed
  • ruff check tests/scripts/test_e2e_smoke.py scripts/e2e_smoke.py passed
  • ruff format --check tests/scripts/test_e2e_smoke.py scripts/e2e_smoke.py passed
  • git diff --check origin/production...HEAD passed

Skipped /cso: no auth, payments, upload/webhook handlers, raw SQL, integration code, deploy config, or secret-value handling changed.

@ohld ohld merged commit 3c3ce30 into production Jun 23, 2026
3 checks passed
@ohld

ohld commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

Approved + merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant