Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
test_animeworld_episode_linkconfronta l'URL del video con un host CDNhardcoded (
srv23-abbaia.sweetpixel.org). Il sottodominio ruota nel tempo e lefixtures si rigenerano dal vivo, quindi il test fallisce a ogni rotazione anche
se
_episode_linkfunziona correttamente.Esempio attuale:
https://srv23-abbaia.sweetpixel.org/DDL/ANIME/Naruto/Naruto_Ep_001_SUB_ITA.mp4https://srv23-masafi.sweetpixel.org/DDL/ANIME/Naruto/Naruto_Ep_001_SUB_ITA.mp4Soluzione
Il test ora verifica solo la parte stabile dell'URL (schema, dominio
sweetpixel.orge path del file), ignorando il nome del server.Nota
Lo stesso fix è incluso come secondo commit in #48. Questa PR lo propone
separatamente, così può essere mergiato indipendentemente dalla modifica ai
download. Se preferisci tenerlo in #48, chiudo questa senza problemi.
Verifica
uv run pyright→ 0 errori, 0 warninguv run pytest→ 65 passed (prima: 64 passed, 1 failed)