fix(preset): disable tilt analytics during version check#158
Merged
Conversation
tilt's analytics init calls getent which isn't available in the clean env that b uses for binary execution. This made 'tilt version' fail with exit code 1, leaving VersionLocalF unable to report the installed version. Set TILT_DISABLE_ANALYTICS=1 in the version check (same pattern as k9s setting K9S_LOGS_DIR and argocd/packer setting HOME). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Disables Tilt analytics during the local version probe so tilt version succeeds in b’s clean execution environment (avoiding update flows treating Tilt’s version as “unknown” and repeatedly re-downloading it).
Changes:
- Set
TILT_DISABLE_ANALYTICS=1inside Tilt’sVersionLocalFbefore runningtilt version.
Comment on lines
+39
to
43
| if b.Envs == nil { | ||
| b.Envs = map[string]string{} | ||
| } | ||
| b.Envs["TILT_DISABLE_ANALYTICS"] = "1" | ||
| s, err := b.Exec("version") |
fentas
pushed a commit
that referenced
this pull request
May 8, 2026
🤖 I have created a release *beep* *boop* --- ## [4.17.1](v4.17.0...v4.17.1) (2026-05-08) ### Bug Fixes * **binary:** revert EnsureBinary unknown-version guard ([#152](#152) regression) ([#156](#156)) ([37428f4](37428f4)) * **preset:** disable tilt analytics during version check ([#158](#158)) ([f30b803](f30b803)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`tilt version` fails in b's clean exec environment because tilt's analytics init calls `getent` which isn't available. This left `VersionLocalF` unable to report the installed version.
Fix
Set `TILT_DISABLE_ANALYTICS=1` inside `VersionLocalF`, same pattern as:
Test plan
🤖 Generated with Claude Code