chore: upgrade vite-plus to 0.1.21-alpha.4#8
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies, including upgrading vite-plus and vitest to version 0.1.21-alpha.4, and introduces a staged configuration in vite.config.ts and the pre-commit hook. The reviewer identified that running vp lint alongside vp staged in the pre-commit hook is redundant and inefficient, suggesting that vp lint should be removed from the pre-commit hook to streamline the local commit process.
| @@ -1 +1,2 @@ | |||
| vp lint | |||
| vp staged | |||
There was a problem hiding this comment.
Running vp staged after vp lint in a pre-commit hook is inefficient and potentially problematic for the following reasons:
- Redundancy:
vp linttypically checks the entire project, whilevp stagedchecks only the files currently being committed. Running both significantly slows down the commit process as the project grows. - Workflow Logic: Since
vp stagedis configured invite.config.tsto runvp check --fix, it is intended to automatically fix issues. Ifvp lintruns first and fails on a staged file that could have been auto-fixed, the commit will abort, forcing the developer to fix the issue manually.
Consider removing vp lint from the pre-commit hook and relying on vp staged for local checks, while keeping the full project linting for CI/CD pipelines.
Upgrade vite-plus and related packages to 0.1.21-alpha.4 alpha version.