Skip to content

chore: upgrade vite-plus to 0.1.20-alpha.4#7

Draft
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-alpha-0.1.20-alpha.4
Draft

chore: upgrade vite-plus to 0.1.20-alpha.4#7
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-alpha-0.1.20-alpha.4

Conversation

@fengmk2

@fengmk2 fengmk2 commented Apr 28, 2026

Copy link
Copy Markdown
Owner

Upgrade vite-plus and related packages to 0.1.20-alpha.4 alpha version.

@fengmk2 fengmk2 self-assigned this Apr 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates project dependencies by pinning vite-plus and related packages to version 0.1.20-alpha.4, configures rootDir in plugin TypeScript settings, and removes esModuleInterop: false from the global and web configurations. It also introduces a staged check in the pre-commit hook and vite.config.ts. In Sidebar.tsx, the use of mutateAsync within Promise.all was identified as a potential source of unhandled promise rejections; it is recommended to add a .catch() handler to ensure individual failures do not disrupt the entire batch process.

items
.filter((i) => i.model === "http_request")
.map((i) => sendAnyHttpRequest.mutate(i.id)),
.map((i) => sendAnyHttpRequest.mutateAsync(i.id)),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since mutateAsync returns a promise that rejects on failure, and this is called within Promise.all inside an async callback that isn't explicitly caught, a failed request will trigger an unhandled promise rejection. Adding a .catch() to the individual mutation calls ensures that the batch process continues and avoids unhandled rejections. This is safe here as individual request states are already tracked and displayed via atoms.

Suggested change
.map((i) => sendAnyHttpRequest.mutateAsync(i.id)),
.map((i) => sendAnyHttpRequest.mutateAsync(i.id).catch(() => {})),

@fengmk2 fengmk2 force-pushed the update-vite-plus-alpha-0.1.20-alpha.4 branch from 9a484e4 to 49fe0ac Compare April 29, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant