Skip to content

chore: upgrade vite-plus to 0.1.19-alpha.3#6

Draft
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-alpha-0.1.19-alpha.3
Draft

chore: upgrade vite-plus to 0.1.19-alpha.3#6
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-alpha-0.1.19-alpha.3

Conversation

@fengmk2

@fengmk2 fengmk2 commented Apr 21, 2026

Copy link
Copy Markdown
Owner

Upgrade vite-plus and related packages to 0.1.19-alpha.3 alpha version.

@fengmk2 fengmk2 self-assigned this Apr 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies to specific versions, notably vite-plus and vitest, and removes unused packages such as rolldown and siginfo. Configuration changes include adding a staged check to the Vite configuration and pre-commit hooks, alongside refinements to TypeScript settings. In Sidebar.tsx, the implementation was updated to use mutateAsync within a Promise.all block; however, it is recommended to use Promise.allSettled instead to ensure all requests are attempted and to prevent the entire batch from rejecting if a single request fails.

@@ -312,7 +312,7 @@ function Sidebar({ className }: { className?: string }) {
await Promise.all(

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Switching to mutateAsync correctly allows Promise.all to wait for the network requests to complete. However, Promise.all will reject immediately if any single mutation fails, which can lead to unhandled promise rejections if not caught. Consider using Promise.allSettled to ensure all requests are attempted even if some fail, or wrap this block in a try...catch to handle potential errors gracefully.

Suggested change
await Promise.all(
await Promise.allSettled(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant