Skip to content

chore: upgrade vite-plus to 0.1.17-alpha.4#4

Draft
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-alpha-0.1.17-alpha.4
Draft

chore: upgrade vite-plus to 0.1.17-alpha.4#4
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-alpha-0.1.17-alpha.4

Conversation

@fengmk2

@fengmk2 fengmk2 commented Apr 13, 2026

Copy link
Copy Markdown
Owner

Upgrade vite-plus and related packages to 0.1.17-alpha.4

@fengmk2 fengmk2 self-assigned this Apr 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request pins vite-plus and vitest to specific alpha versions, updates internal dependencies, and adds a pre-commit hook for staged files. It also adjusts TypeScript configurations, such as defining rootDir in plugin packages. Feedback recommends explicitly setting esModuleInterop to true in the root and web tsconfig.json files to improve module compatibility instead of relying on the default false value.

Comment thread tsconfig.json
"allowJs": false,
"skipLibCheck": true,
"esModuleInterop": false,
"allowSyntheticDefaultImports": true,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While removing the explicit false value is a good cleanup, TypeScript still defaults esModuleInterop to false. In modern projects, especially those using Vite and React, it is highly recommended to set "esModuleInterop": true. This ensures better compatibility with CommonJS modules and provides a more consistent experience when importing libraries that don't have a default export. Since allowSyntheticDefaultImports is already enabled, setting esModuleInterop to true is the preferred way to handle these imports correctly at both compile-time and runtime.

Suggested change
"allowSyntheticDefaultImports": true,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,

Comment thread src-web/tsconfig.json
"allowJs": false,
"skipLibCheck": true,
"esModuleInterop": false,
"allowSyntheticDefaultImports": true,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For web projects, enabling esModuleInterop is standard practice to avoid runtime issues with CommonJS dependencies. Instead of just removing the explicit false value, consider setting it to true to align with modern TypeScript standards and ensure robust module interop.

Suggested change
"allowSyntheticDefaultImports": true,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant