Skip to content

feat(deps): upgrade vite-plus to 0.1.15-alpha.7#2

Draft
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-alpha-0.1.15-alpha.7
Draft

feat(deps): upgrade vite-plus to 0.1.15-alpha.7#2
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-alpha-0.1.15-alpha.7

Conversation

@fengmk2

@fengmk2 fengmk2 commented Mar 31, 2026

Copy link
Copy Markdown
Owner

Upgrade vite-plus and related packages to 0.1.15-alpha.7

@fengmk2 fengmk2 self-assigned this Mar 31, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request pins vite-plus and vitest to specific alpha versions, adds a staged linting step to the pre-commit hook, and modifies HTTP body building logic. Feedback was provided regarding the removal of explicit Content-Type headers for GraphQL and form-urlencoded requests, which could lead to missing headers. Additionally, the package-lock.json should be updated to use the official npm registry instead of a mirror for consistency.

Comment on lines +229 to +230
"graphql" => (build_graphql_body(&method, &body), None),
"application/x-www-form-urlencoded" => (build_form_body(&body), None),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The removal of explicit Content-Type values for graphql and application/x-www-form-urlencoded may lead to incorrect or missing headers in outgoing requests. For GraphQL, the mapping to application/json is standard and should be preserved. For form-urlencoded, while the body_type string matches the MIME type, returning None here relies on the caller to correctly fallback, which might not be the case for all HTTP clients or server expectations.

Suggested change
"graphql" => (build_graphql_body(&method, &body), None),
"application/x-www-form-urlencoded" => (build_form_body(&body), None),
"graphql" => (build_graphql_body(&method, &body), Some("application/json".to_string())),
"application/x-www-form-urlencoded" => (build_form_body(&body), Some("application/x-www-form-urlencoded".to_string())),

Comment thread package-lock.json
"resolved": "https://registry.npmjs.org/@oxc-project/runtime/-/runtime-0.115.0.tgz",
"integrity": "sha512-Rg8Wlt5dCbXhQnsXPrkOjL1DTSvXLgb2R/KYfnf1/K+R0k6UMLEmbQXPM+kwrWqSmWA2t0B1EtHy2/3zikQpvQ==",
"version": "0.122.0",
"resolved": "https://registry.npmmirror.com/@oxc-project/runtime/-/runtime-0.122.0.tgz",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The registry URL has been changed from registry.npmjs.org to registry.npmmirror.com. This typically occurs when a local mirror is configured in the environment where npm install was run. It is recommended to use the official npm registry in the lockfile to ensure consistency and security across different development environments.

@fengmk2 fengmk2 closed this Mar 31, 2026
@fengmk2 fengmk2 reopened this Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant