chore: upgrade vite-plus to 0.1.19-alpha.3#1
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the workspace dependencies, specifically pinning vite, vitest, and vite-plus to version 0.1.19-alpha.3 across pnpm-workspace.yaml and pnpm-lock.yaml. Feedback was provided regarding inconsistencies in the lockfile, specifically noting that the catalogs, overrides, and importers sections should use the catalog: specifier or include missing entries to ensure proper synchronization with the workspace configuration. It is recommended to regenerate the lockfile using pnpm install to resolve these discrepancies.
| vite-plus: | ||
| specifier: latest | ||
| version: 0.1.12 | ||
| specifier: 0.1.19-alpha.3 | ||
| version: 0.1.19-alpha.3 |
There was a problem hiding this comment.
The catalogs section in the lockfile is missing entries for vite and vitest, which are defined in pnpm-workspace.yaml and used in package.json. This indicates the lockfile was likely manually edited or incorrectly updated, bypassing the catalog synchronization feature. It is recommended to regenerate the lockfile using pnpm install.
vite:
specifier: npm:@voidzero-dev/vite-plus-core@0.1.19-alpha.3
version: 0.1.19-alpha.3
vite-plus:
specifier: 0.1.19-alpha.3
version: 0.1.19-alpha.3
vitest:
specifier: npm:@voidzero-dev/vite-plus-test@0.1.19-alpha.3
version: 0.1.19-alpha.3| vite: npm:@voidzero-dev/vite-plus-core@0.1.19-alpha.3 | ||
| vitest: npm:@voidzero-dev/vite-plus-test@0.1.19-alpha.3 |
There was a problem hiding this comment.
The overrides section in the lockfile should use the catalog: specifier to match the configuration in pnpm-workspace.yaml. Hardcoding the resolved alias here defeats the purpose of using a centralized catalog.
vite: 'catalog:'
vitest: 'catalog:'| vite: | ||
| specifier: npm:@voidzero-dev/vite-plus-core@latest | ||
| version: '@voidzero-dev/vite-plus-core@0.1.12(@types/node@25.5.0)(esbuild@0.27.3)(jiti@2.6.1)(typescript@5.9.3)(yaml@2.7.0)' | ||
| specifier: npm:@voidzero-dev/vite-plus-core@0.1.19-alpha.3 |
There was a problem hiding this comment.
The specifier for vite in the importers section should be catalog: to match the definition in package.json. The current hardcoded alias specifier is inconsistent with the vite-plus entry (line 104) and breaks catalog synchronization.
specifier: 'catalog:'| vitest: | ||
| specifier: npm:@voidzero-dev/vite-plus-test@latest | ||
| version: '@voidzero-dev/vite-plus-test@0.1.12(@types/node@25.5.0)(@voidzero-dev/vite-plus-core@0.1.12(@types/node@25.5.0)(esbuild@0.27.3)(jiti@2.6.1)(typescript@5.9.3)(yaml@2.7.0))(esbuild@0.27.3)(jiti@2.6.1)(typescript@5.9.3)(yaml@2.7.0)' | ||
| specifier: npm:@voidzero-dev/vite-plus-test@0.1.19-alpha.3 |
There was a problem hiding this comment.
The specifier for vitest in the importers section should be catalog: to match the definition in package.json. The current hardcoded alias specifier is inconsistent with the vite-plus entry (line 104) and breaks catalog synchronization.
specifier: 'catalog:'1 participant
Upgrade vite-plus and related packages to 0.1.19-alpha.3 alpha version.