Skip to content

chore(deps): bump vite-plus to pkg-pr-new PR #1703#16

Draft
fengmk2 wants to merge 3 commits into
mainfrom
update-vite-plus-prerelease-test-pr-1703
Draft

chore(deps): bump vite-plus to pkg-pr-new PR #1703#16
fengmk2 wants to merge 3 commits into
mainfrom
update-vite-plus-prerelease-test-pr-1703

Conversation

@fengmk2

@fengmk2 fengmk2 commented May 28, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus and related packages to the pkg-pr-new prerelease build for upstream PR voidzero-dev/vite-plus#1703 (commit d0b407c).

Updated where applicable:

  • vite-plus
  • vitest (alias to @voidzero-dev/vite-plus-test)
  • vite (alias to @voidzero-dev/vite-plus-core)
  • overrides / resolutions / pnpm.overrides / pnpm-workspace.yaml catalogs
  • minimumReleaseAge configuration

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pnpm-workspace.yaml configuration to disable blockExoticSubdeps, add package exclusions for minimumReleaseAge, and point several vite-plus dependencies to pre-release builds hosted on pkg.pr.new. Feedback highlights an inconsistency where catalog definitions use a PR number while overrides use a specific commit hash, which could lead to duplicate package installations. It is recommended to align both to use the same commit hash.

Comment thread pnpm-workspace.yaml
Comment on lines +93 to +97
vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1703
vite-plugin-commonjs: ^0.10.4
vite-plus: 0.1.22
vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@1703
vite-tsconfig-paths: ^6.1.1
vitest: npm:@voidzero-dev/vite-plus-test@0.1.22
vitest: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1703

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There is an inconsistency between the catalog definitions (which use the PR number @1703) and the overrides (which use the specific commit hash @d0b407c85b560c2470395176c9f1c838b5ca8af8).

Using different URLs for the same packages can cause pnpm to treat them as separate versions, potentially leading to duplicate installations of core packages like vite and vitest in the monorepo. To ensure consistency and deterministic builds, update the catalog entries to use the exact same commit hash as the overrides.

  vite: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8
  vite-plugin-commonjs: ^0.10.4
  vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@d0b407c85b560c2470395176c9f1c838b5ca8af8
  vite-tsconfig-paths: ^6.1.1
  vitest: https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@d0b407c85b560c2470395176c9f1c838b5ca8af8

@fengmk2 fengmk2 changed the title chore(deps): bump vite-plus to pkg-pr-new PR #1703 (d0b407c) chore(deps): bump vite-plus to pkg-pr-new PR #1703 May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant