chore(deps): bump vite-plus to pkg-pr-new pr-1588#8
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates dependency configurations in package.json and pnpm-workspace.yaml, switching several dependencies to preview releases and simplifying the minimumReleaseAgeExclude list using wildcards. A critical issue was identified in package.json where the vite override and @voidzero-dev/vite-plus-core override use different version specifiers (a PR branch version versus a specific commit SHA). This mismatch will prevent pnpm from deduplicating the packages, potentially leading to multiple instances of the core package being installed. It is recommended to align both overrides to the same commit SHA.
| "@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@5577b0154f33d1480a3c96347e94fa5d2094de2e", | ||
| "@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@5577b0154f33d1480a3c96347e94fa5d2094de2e", | ||
| "vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1588" |
There was a problem hiding this comment.
The vite override is currently pointing to the PR branch version (@1588), while @voidzero-dev/vite-plus-core is pinned to a specific commit SHA (@5577b0154f33d1480a3c96347e94fa5d2094de2e). Since vite is mapped to @voidzero-dev/vite-plus-core, using different specifiers/URLs will cause pnpm to treat them as different packages, preventing deduplication and potentially installing multiple copies of the core package.
To ensure consistency and avoid duplicate package instances, please pin the vite override to the same commit SHA.
| "@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@5577b0154f33d1480a3c96347e94fa5d2094de2e", | |
| "@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@5577b0154f33d1480a3c96347e94fa5d2094de2e", | |
| "vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1588" | |
| "@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@5577b0154f33d1480a3c96347e94fa5d2094de2e", | |
| "@voidzero-dev/vite-plus-prompts": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-prompts@5577b0154f33d1480a3c96347e94fa5d2094de2e", | |
| "vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@5577b0154f33d1480a3c96347e94fa5d2094de2e" |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 10 10
Lines 730 730
Branches 228 228
=======================================
Hits 691 691
Misses 36 36
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: MK (fengmk2) <fengmk2@gmail.com>
Summary
Bump vite-plus to pkg-pr-new build for PR #1588 (replace @voidzero-dev/vite-plus-test wrapper with upstream vitest@4.1.5).
Test plan