chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#7
Conversation
commit: |
There was a problem hiding this comment.
Code Review
This pull request updates the project's dependencies, specifically transitioning vite-plus and vitest from versioned npm packages to specific PR-based URLs. The feedback suggests improving the dependency aliasing in package.json by using the npm: prefix for better tracking by pnpm. Additionally, it is recommended to expand the pnpm.overrides section to include scoped package names; this would address an issue where duplicate versions of the same package are being installed due to differing resolution paths in the lockfile.
| "vite-plus": "^0.1.21", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@^0.1.21" | ||
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633", | ||
| "vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633" |
There was a problem hiding this comment.
To maintain consistency with the previous aliasing pattern and ensure the package name is explicitly tracked by pnpm, it's recommended to use the npm: prefix when aliasing a dependency to a URL.
| "vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633" | |
| "vitest": "npm:@voidzero-dev/vite-plus-test@https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633" |
| "vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1633", | ||
| "vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633" |
There was a problem hiding this comment.
The current overrides only target the vite and vitest aliases. However, the vite-plus package (and its sub-packages) depends directly on the scoped package names (@voidzero-dev/vite-plus-core and @voidzero-dev/vite-plus-test).
Because the PR version of vite-plus uses commit-specific URLs for its internal dependencies, while this package.json uses the PR number alias, pnpm is currently installing duplicate versions of these packages (as seen in the lockfile duplication between @1633 and the specific commit hash 428629ad...). Adding overrides for the scoped package names will ensure consistency and deduplicate them in the lockfile.
"vite": "npm:@voidzero-dev/vite-plus-core@https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1633",
"vitest": "npm:@voidzero-dev/vite-plus-test@https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633",
"@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1633",
"@voidzero-dev/vite-plus-test": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633"
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 10 10
Lines 730 730
Branches 228 228
=======================================
Hits 691 691
Misses 36 36
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Bump
vite-plusand related@voidzero-dev/*packages to the pkg-pr-new prerelease for vite-plus PR #1633.Updated where applicable:
vite-plus→https://pkg.pr.new/voidzero-dev/vite-plus@1633vitealias →@voidzero-dev/vite-plus-corepkg-pr-new URLvitestalias →@voidzero-dev/vite-plus-testpkg-pr-new URLoverrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsAlso configured
minimum-release-agewith vite-plus /@voidzero-dev/*excluded for pnpm / bun / npm.Test plan