Skip to content

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#7

Draft
fengmk2 wants to merge 1 commit into
masterfrom
update-vite-plus-prerelease-test-pr-1633
Draft

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#7
fengmk2 wants to merge 1 commit into
masterfrom
update-vite-plus-prerelease-test-pr-1633

Conversation

@fengmk2

@fengmk2 fengmk2 commented May 19, 2026

Copy link
Copy Markdown
Owner

Summary

Bump vite-plus and related @voidzero-dev/* packages to the pkg-pr-new prerelease for vite-plus PR #1633.

Updated where applicable:

  • vite-plushttps://pkg.pr.new/voidzero-dev/vite-plus@1633
  • vite alias → @voidzero-dev/vite-plus-core pkg-pr-new URL
  • vitest alias → @voidzero-dev/vite-plus-test pkg-pr-new URL
  • overrides / resolutions / pnpm.overrides / pnpm-workspace.yaml catalogs

Also configured minimum-release-age with vite-plus / @voidzero-dev/* excluded for pnpm / bun / npm.

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 19, 2026
@pkg-pr-new

pkg-pr-new Bot commented May 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/fengmk2/urllib@7

commit: 1dc3d50

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project's dependencies, specifically transitioning vite-plus and vitest from versioned npm packages to specific PR-based URLs. The feedback suggests improving the dependency aliasing in package.json by using the npm: prefix for better tracking by pnpm. Additionally, it is recommended to expand the pnpm.overrides section to include scoped package names; this would address an issue where duplicate versions of the same package are being installed due to differing resolution paths in the lockfile.

Comment thread package.json
"vite-plus": "^0.1.21",
"vitest": "npm:@voidzero-dev/vite-plus-test@^0.1.21"
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633",
"vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the previous aliasing pattern and ensure the package name is explicitly tracked by pnpm, it's recommended to use the npm: prefix when aliasing a dependency to a URL.

Suggested change
"vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633"
"vitest": "npm:@voidzero-dev/vite-plus-test@https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633"

Comment thread package.json
Comment on lines +117 to +118
"vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1633",
"vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current overrides only target the vite and vitest aliases. However, the vite-plus package (and its sub-packages) depends directly on the scoped package names (@voidzero-dev/vite-plus-core and @voidzero-dev/vite-plus-test).

Because the PR version of vite-plus uses commit-specific URLs for its internal dependencies, while this package.json uses the PR number alias, pnpm is currently installing duplicate versions of these packages (as seen in the lockfile duplication between @1633 and the specific commit hash 428629ad...). Adding overrides for the scoped package names will ensure consistency and deduplicate them in the lockfile.

      "vite": "npm:@voidzero-dev/vite-plus-core@https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1633",
      "vitest": "npm:@voidzero-dev/vite-plus-test@https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633",
      "@voidzero-dev/vite-plus-core": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1633",
      "@voidzero-dev/vite-plus-test": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633"

@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.65%. Comparing base (07570c6) to head (1dc3d50).

Additional details and impacted files
@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files          10       10           
  Lines         730      730           
  Branches      228      228           
=======================================
  Hits          691      691           
  Misses         36       36           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant