chore(deps): bump vite-plus to pkg-pr-new PR #1703#7
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the pnpm-workspace.yaml file to use specific pkg.pr.new URLs for dependencies in the catalog and overrides, and configures release age exclusions. The reviewer pointed out an inconsistency between the PR-based versions used in the catalog and the commit-hash-based versions used in the overrides, which could lead to duplication issues and lack of build reproducibility. It is recommended to align both to use the same commit hash.
| vite: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1703' | ||
| vitest: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1703' | ||
| vite-plus: 'https://pkg.pr.new/voidzero-dev/vite-plus@1703' |
There was a problem hiding this comment.
There is an inconsistency between the package specifiers used in the catalog (which use the PR number @1703) and those used in the overrides (which use the specific commit hash @d0b407c85b560c2470395176c9f1c838b5ca8af8).\n\nUsing different specifiers for the same packages can prevent pnpm from properly deduplicating them, potentially leading to duplicate installations of the core packages (e.g., @voidzero-dev/vite-plus-core and @voidzero-dev/vite-plus-test) under different resolved versions. In frontend tooling, duplicate package instances often cause runtime issues due to shared state or multiple registrations.\n\nAdditionally, using the commit-specific hash is highly recommended over the PR number to ensure build reproducibility, as PR-based builds can change when new commits are pushed to the upstream PR.\n\nPlease update the catalog entries to use the same commit hash as the overrides.
vite: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8'\n vitest: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@d0b407c85b560c2470395176c9f1c838b5ca8af8'\n vite-plus: 'https://pkg.pr.new/voidzero-dev/vite-plus@d0b407c85b560c2470395176c9f1c838b5ca8af8'
commit: |
Summary
Bump
vite-plusand related packages to the pkg-pr-new prerelease build for upstream PR voidzero-dev/vite-plus#1703 (commit d0b407c).Test plan