chore(deps): bump vite-plus to pkg-pr-new pr-1588#6
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates pnpm-workspace.yaml to configure specific preview versions for vite-plus and its core dependencies, while also adding release age exclusion rules. The review feedback highlights two important issues: a potential version mismatch risk where vite-plus is set to a PR branch identifier while its sub-dependencies are pinned to a specific commit hash, and the removal of vitest: 'catalog:' from overrides, which could lead to inconsistent transitive dependency versions of Vitest across the workspace.
| vitest: npm:@voidzero-dev/vite-plus-test@latest | ||
| vite-plus: latest | ||
| vitest: ^4.1.5 | ||
| vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@1588 |
There was a problem hiding this comment.
There is a potential version mismatch risk here. vite-plus is configured to use the PR branch identifier @1588 (which always resolves to the latest commit of that PR), whereas the overrides for @voidzero-dev/vite-plus-core and @voidzero-dev/vite-plus-prompts are pinned to a specific commit hash (5577b0154f33d1480a3c96347e94fa5d2094de2e).
If a new commit is pushed to PR 1588, vite-plus will resolve to the new commit while its core dependencies remain locked to the older commit, potentially causing runtime or build-time incompatibilities.
Consider pinning vite-plus to the same commit hash to ensure consistency.
vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@5577b0154f33d1480a3c96347e94fa5d2094de2e| vitest: ^4.1.5 | ||
| vite-plus: https://pkg.pr.new/voidzero-dev/vite-plus@1588 | ||
| overrides: | ||
| vite: 'catalog:' |
There was a problem hiding this comment.
Removing vitest: 'catalog:' from overrides allows transitive dependencies to resolve to different versions of vitest instead of the workspace-wide catalog version (^4.1.5).
To ensure strict version consistency across the entire workspace (especially for test runners like Vitest where multiple active versions can cause runtime issues or duplicate test runs), it is highly recommended to keep vitest: 'catalog:' in overrides.
vite: 'catalog:'
vitest: 'catalog:'
commit: |
commit: |
1 participant
Summary
Bump vite-plus to pkg-pr-new build for PR #1588 (replace @voidzero-dev/vite-plus-test with upstream vitest@4.1.5).
Test plan