chore(deps): bump vite-plus to pkg-pr-new PR #1703#7
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the dependencies in package.json and pnpm-workspace.yaml to use preview releases from pkg.pr.new. The reviewer identified a mismatch between the versions used in the catalog (which use the PR number @1703) and the overrides (which use a specific commit hash). To ensure consistency and reproducible builds, it is recommended to align all dependencies to use the same commit hash specifier.
| vite: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1703' | ||
| vitest: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1703' | ||
| vite-plus: 'https://pkg.pr.new/voidzero-dev/vite-plus@1703' |
There was a problem hiding this comment.
There is a mismatch between the versions used in the catalog (which use the PR number @1703) and the overrides (which use the commit hash @d0b407c85b560c2470395176c9f1c838b5ca8af8). This mismatch can cause pnpm to resolve and install two different versions of the same packages (one for direct catalog dependencies and another for subdependencies), leading to duplicate packages and potential runtime issues.
We should align them to use the same specifier. Using the commit hash is generally preferred for immutability and reproducible builds.
vite: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8'
vitest: 'https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@d0b407c85b560c2470395176c9f1c838b5ca8af8'
vite-plus: 'https://pkg.pr.new/voidzero-dev/vite-plus@d0b407c85b560c2470395176c9f1c838b5ca8af8'| "vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1703", | ||
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1703" |
There was a problem hiding this comment.
To maintain consistency with the overrides in pnpm-workspace.yaml and ensure reproducible builds, we should use the commit hash @d0b407c85b560c2470395176c9f1c838b5ca8af8 instead of the PR number @1703.
| "vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1703", | |
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1703" | |
| "vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@d0b407c85b560c2470395176c9f1c838b5ca8af8", | |
| "vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@d0b407c85b560c2470395176c9f1c838b5ca8af8" |
Summary
Bump vite-plus and related packages to the pkg-pr-new prerelease build for upstream PR voidzero-dev/vite-plus#1703 (commit d0b407c).
Test plan